From 2cf86a35541d64693ce7f7d60bab3593ff29a316 Mon Sep 17 00:00:00 2001 From: Paulus Schoutsen Date: Thu, 14 Nov 2019 14:34:13 +0100 Subject: [PATCH] Fix account link version check (#28770) --- homeassistant/components/cloud/account_link.py | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/homeassistant/components/cloud/account_link.py b/homeassistant/components/cloud/account_link.py index 6fbfcc8723b..9ec1fe634d7 100644 --- a/homeassistant/components/cloud/account_link.py +++ b/homeassistant/components/cloud/account_link.py @@ -13,7 +13,6 @@ from .const import DOMAIN DATA_SERVICES = "cloud_account_link_services" CACHE_TIMEOUT = 3600 -PATCH_VERSION = int(PATCH_VERSION.split(".")[0]) _LOGGER = logging.getLogger(__name__) @@ -49,7 +48,20 @@ def _is_older(version: str) -> bool: except ValueError: return False - cur_version_parts = [MAJOR_VERSION, MINOR_VERSION, PATCH_VERSION] + patch_number_str = "" + + for char in PATCH_VERSION: + if char.isnumeric(): + patch_number_str += char + else: + break + + try: + patch_number = int(patch_number_str) + except ValueError: + patch_number = 0 + + cur_version_parts = [MAJOR_VERSION, MINOR_VERSION, patch_number] return version_parts <= cur_version_parts