evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Catch Shelly zeroconf types with uppercase too (#44672)

Browse source 
Co-authored-by: Franck Nijhof <git@frenck.dev>
This commit is contained in:
Paulus Schoutsen 2021-01-01 20:54:43 +01:00 • committed by GitHub
parent c7fa98211d
commit 2b0556520b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

3
homeassistant/components/shelly/config_flow.py
View file

@ -138,9 +138,6 @@ class ConfigFlow(config_entries.ConfigFlow, domain=DOMAIN):
async def async_step_zeroconf(self, zeroconf_info): async def async_step_zeroconf(self, zeroconf_info):
"""Handle zeroconf discovery.""" """Handle zeroconf discovery."""
if not zeroconf_info.get("name", "").startswith("shelly"):
return self.async_abort(reason="not_shelly")
try: try:
self.info = info = await self._async_get_info(zeroconf_info["host"]) self.info = info = await self._async_get_info(zeroconf_info["host"])
except HTTP_CONNECT_ERRORS: except HTTP_CONNECT_ERRORS:

11
tests/components/shelly/test_config_flow.py
View file

@ -488,14 +488,3 @@ async def test_zeroconf_require_auth(hass):
} }
assert len(mock_setup.mock_calls) == 1 assert len(mock_setup.mock_calls) == 1
assert len(mock_setup_entry.mock_calls) == 1 assert len(mock_setup_entry.mock_calls) == 1
async def test_zeroconf_not_shelly(hass):
"""Test we filter out non-shelly devices."""
result = await hass.config_entries.flow.async_init(
DOMAIN,
data={"host": "1.1.1.1", "name": "notshelly"},
context={"source": config_entries.SOURCE_ZEROCONF},
)
assert result["type"] == "abort"
assert result["reason"] == "not_shelly"