evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

minimal fixes in the owntracks mqtt device tracker (#9866)

Browse source 
* fix UnboundLocalError when unable to parse payload, and show bad topics that cannot be parsed ok

* Update owntracks.py
This commit is contained in:
Eugenio Panadero 2017-10-15 00:46:06 +02:00 • committed by Paulus Schoutsen
parent 00244380a8
commit 26cb67dec2
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
homeassistant/components/device_tracker/owntracks.py
View file

@ -75,6 +75,7 @@ def async_setup_scanner(hass, config, async_see, discovery_info=None):
except ValueError: except ValueError:
# If invalid JSON # If invalid JSON
_LOGGER.error("Unable to parse payload as JSON: %s", payload) _LOGGER.error("Unable to parse payload as JSON: %s", payload)
return
message['topic'] = topic message['topic'] = topic
@ -91,7 +92,11 @@ def _parse_topic(topic):
Async friendly. Async friendly.
""" """
_, user, device, *_ = topic.split('/', 3) try:
_, user, device, *_ = topic.split('/', 3)
except ValueError:
_LOGGER.error("Can't parse topic: '%s'", topic)
raise
return user, device return user, device