evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Code fixes and cleanup for roomba integration (#34409)

Browse source 
* Remove side effects from properties

* Remove redundant return value in async_send_command

* Move callback registeration to async_added_to_hass

* Code cleanup for roomba
This commit is contained in:
Xiaonan Shen 2020-04-19 03:26:53 -07:00 • committed by GitHub
parent 7a8d1c00a4
commit 2686869f88
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

7
homeassistant/components/roomba/binary_sensor.py
View file

@ -18,7 +18,6 @@ async def async_setup_entry(hass, config_entry, async_add_entities):
status = roomba_reported_state(roomba).get("bin", {})
if "full" in status:
roomba_vac = RoombaBinStatus(roomba, blid)
roomba_vac.register_callback()
async_add_entities([roomba_vac], True)
@ -45,8 +44,4 @@ class RoombaBinStatus(IRobotEntity, BinarySensorDevice):
@property
def state(self):
"""Return the state of the sensor."""
bin_status = (
roomba_reported_state(self.vacuum).get("bin", {}).get("full", False)
)
_LOGGER.debug("Update Full Bin status from the vacuum: %s", bin_status)
return bin_status
return roomba_reported_state(self.vacuum).get("bin", {}).get("full", False)