evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix auto_bypass in alarmdecoder (#30961)

Browse source 
* Fix auto_bypass in alarmdecoder

* Address review comments: used dict[key] and renamed variable

* Use dict[key] for required or optional config keys with default values
This commit is contained in:
springstan 2020-02-01 10:01:42 +01:00 • committed by GitHub
parent 0a90b01e77
commit 26415f6abd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
homeassistant/components/alarmdecoder/__init__.py
View file

@ -118,11 +118,12 @@ def setup(hass, config):
conf = config.get(DOMAIN) conf = config.get(DOMAIN)
restart = False restart = False
device = conf.get(CONF_DEVICE) device = conf[CONF_DEVICE]
display = conf.get(CONF_PANEL_DISPLAY) display = conf[CONF_PANEL_DISPLAY]
auto_bypass = conf[CONF_AUTO_BYPASS]
zones = conf.get(CONF_ZONES) zones = conf.get(CONF_ZONES)
device_type = device.get(CONF_DEVICE_TYPE) device_type = device[CONF_DEVICE_TYPE]
host = DEFAULT_DEVICE_HOST host = DEFAULT_DEVICE_HOST
port = DEFAULT_DEVICE_PORT port = DEFAULT_DEVICE_PORT
path = DEFAULT_DEVICE_PATH path = DEFAULT_DEVICE_PATH
@ -204,7 +205,9 @@ def setup(hass, config):
hass.bus.async_listen_once(EVENT_HOMEASSISTANT_STOP, stop_alarmdecoder) hass.bus.async_listen_once(EVENT_HOMEASSISTANT_STOP, stop_alarmdecoder)
load_platform(hass, "alarm_control_panel", DOMAIN, conf, config) load_platform(
hass, "alarm_control_panel", DOMAIN, {CONF_AUTO_BYPASS: auto_bypass}, config
)
if zones: if zones:
load_platform(hass, "binary_sensor", DOMAIN, {CONF_ZONES: zones}, config) load_platform(hass, "binary_sensor", DOMAIN, {CONF_ZONES: zones}, config)

14
homeassistant/components/alarmdecoder/alarm_control_panel.py
View file

@ -21,7 +21,7 @@ from homeassistant.const import (
) )
import homeassistant.helpers.config_validation as cv import homeassistant.helpers.config_validation as cv
from . import DATA_AD, DOMAIN, SIGNAL_PANEL_MESSAGE from . import CONF_AUTO_BYPASS, DATA_AD, DOMAIN, SIGNAL_PANEL_MESSAGE
_LOGGER = logging.getLogger(__name__) _LOGGER = logging.getLogger(__name__)
@ -35,13 +35,17 @@ ALARM_KEYPRESS_SCHEMA = vol.Schema({vol.Required(ATTR_KEYPRESS): cv.string})
def setup_platform(hass, config, add_entities, discovery_info=None): def setup_platform(hass, config, add_entities, discovery_info=None):
"""Set up for AlarmDecoder alarm panels.""" """Set up for AlarmDecoder alarm panels."""
device = AlarmDecoderAlarmPanel(discovery_info["autobypass"]) if discovery_info is None:
add_entities([device]) return
auto_bypass = discovery_info[CONF_AUTO_BYPASS]
entity = AlarmDecoderAlarmPanel(auto_bypass)
add_entities([entity])
def alarm_toggle_chime_handler(service): def alarm_toggle_chime_handler(service):
"""Register toggle chime handler.""" """Register toggle chime handler."""
code = service.data.get(ATTR_CODE) code = service.data.get(ATTR_CODE)
device.alarm_toggle_chime(code) entity.alarm_toggle_chime(code)
hass.services.register( hass.services.register(
DOMAIN, DOMAIN,
@ -53,7 +57,7 @@ def setup_platform(hass, config, add_entities, discovery_info=None):
def alarm_keypress_handler(service): def alarm_keypress_handler(service):
"""Register keypress handler.""" """Register keypress handler."""
keypress = service.data[ATTR_KEYPRESS] keypress = service.data[ATTR_KEYPRESS]
device.alarm_keypress(keypress) entity.alarm_keypress(keypress)
hass.services.register( hass.services.register(
DOMAIN, DOMAIN,