evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make panel_custom backwards compatible (#36926)

Browse source
This commit is contained in:
Paulus Schoutsen 2020-06-19 07:03:39 -07:00 • committed by GitHub
parent 212660330f
commit 263bdaa565
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

24
tests/components/panel_custom/test_init.py
View file

@ -30,19 +30,22 @@ async def test_webcomponent_custom_path_not_found(hass):
assert "nice_url" not in panels
async def test_webcomponent_custom_path(hass):
async def test_webcomponent_custom_path(hass, caplog):
"""Test if a web component is found in config panels dir."""
filename = "mock.file"
config = {
"panel_custom": {
"name": "todo-mvc",
"webcomponent_path": filename,
"sidebar_title": "Sidebar Title",
"sidebar_icon": "mdi:iconicon",
"url_path": "nice_url",
"config": {"hello": "world"},
}
"panel_custom": [
{
"name": "todo-mvc",
"webcomponent_path": filename,
"sidebar_title": "Sidebar Title",
"sidebar_icon": "mdi:iconicon",
"url_path": "nice_url",
"config": {"hello": "world"},
},
{"name": "todo-mvc"},
]
}
with patch("os.path.isfile", Mock(return_value=True)):
@ -70,6 +73,8 @@ async def test_webcomponent_custom_path(hass):
assert panel.sidebar_icon == "mdi:iconicon"
assert panel.sidebar_title == "Sidebar Title"
assert "Got HTML panel with duplicate name todo-mvc. Not registering" in caplog.text
async def test_js_webcomponent(hass):
"""Test if a web component is found in config panels dir."""
@ -186,7 +191,6 @@ async def test_latest_and_es5_build(hass):
async def test_url_option_conflict(hass):
"""Test config with multiple url options."""
to_try = [
{"panel_custom": {"name": "todo-mvc"}},
{
"panel_custom": {
"name": "todo-mvc",