evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove logic to mark litterrobot vacuum entity as unavailable (#73234)

Browse source
This commit is contained in:
Nathan Spencer 2022-06-10 15:16:47 -06:00 • committed by GitHub
parent e4f354998d
commit 21cfbe875e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

7
homeassistant/components/litterrobot/vacuum.py
View file

@ -1,7 +1,6 @@
"""Support for Litter-Robot "Vacuum"."""
from __future__ import annotations
from datetime import datetime, timedelta, timezone
import logging
from typing import Any
@ -46,7 +45,6 @@ LITTER_BOX_STATUS_STATE_MAP = {
LitterBoxStatus.CAT_SENSOR_INTERRUPTED: STATE_PAUSED,
LitterBoxStatus.OFF: STATE_OFF,
}
UNAVAILABLE_AFTER = timedelta(minutes=30)
async def async_setup_entry(
@ -96,11 +94,6 @@ class LitterRobotCleaner(LitterRobotControlEntity, StateVacuumEntity):
| VacuumEntityFeature.TURN_ON
)
@property
def available(self) -> bool:
"""Return True if the cleaner has been seen recently."""
return self.robot.last_seen > datetime.now(timezone.utc) - UNAVAILABLE_AFTER
@property
def state(self) -> str:
"""Return the state of the cleaner."""

10
tests/components/litterrobot/conftest.py
View file

@ -1,7 +1,6 @@
"""Configure pytest for Litter-Robot tests."""
from __future__ import annotations
from datetime import datetime
from typing import Any
from unittest.mock import AsyncMock, MagicMock, patch
@ -10,7 +9,6 @@ from pylitterbot.exceptions import InvalidCommandException
import pytest
from homeassistant.components import litterrobot
from homeassistant.components.litterrobot.vacuum import UNAVAILABLE_AFTER
from homeassistant.core import HomeAssistant
from .common import CONFIG, ROBOT_DATA
@ -73,14 +71,6 @@ def mock_account_with_sleep_disabled_robot() -> MagicMock:
return create_mock_account({"sleepModeActive": "0"})
@pytest.fixture
def mock_account_with_robot_not_recently_seen() -> MagicMock:
"""Mock a Litter-Robot account with a sleeping robot."""
return create_mock_account(
{"lastSeen": (datetime.now() - UNAVAILABLE_AFTER).isoformat()}
)
@pytest.fixture
def mock_account_with_error() -> MagicMock:
"""Mock a Litter-Robot account with error."""

15
tests/components/litterrobot/test_vacuum.py
View file

@ -24,7 +24,7 @@ from homeassistant.components.vacuum import (
STATE_DOCKED,
STATE_ERROR,
)
from homeassistant.const import ATTR_ENTITY_ID, STATE_UNAVAILABLE
from homeassistant.const import ATTR_ENTITY_ID
from homeassistant.core import HomeAssistant
from homeassistant.util.dt import utcnow
@ -62,19 +62,6 @@ async def test_vacuum_status_when_sleeping(
assert vacuum.attributes.get(ATTR_STATUS) == "Ready (Sleeping)"
async def test_vacuum_state_when_not_recently_seen(
hass: HomeAssistant, mock_account_with_robot_not_recently_seen: MagicMock
) -> None:
"""Tests the vacuum state when not seen recently."""
await setup_integration(
hass, mock_account_with_robot_not_recently_seen, PLATFORM_DOMAIN
)
vacuum = hass.states.get(VACUUM_ENTITY_ID)
assert vacuum
assert vacuum.state == STATE_UNAVAILABLE
async def test_no_robots(
hass: HomeAssistant, mock_account_with_no_robots: MagicMock
) -> None: