From 200a5c7e05e83a265e26d8aff09dc6a043826884 Mon Sep 17 00:00:00 2001 From: Allen Porter Date: Tue, 7 Dec 2021 07:40:36 -0800 Subject: [PATCH] Fix flaky tests with unsynchronized stream `available` assertions (#61167) Remove assertions that are not guaratuneed to be safe depending on the state of the background worker. This leaves in the state check for the keepalive case which does have some synchronization already. --- tests/components/stream/test_hls.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/components/stream/test_hls.py b/tests/components/stream/test_hls.py index 9c529d7abe5..5e0ee15f097 100644 --- a/tests/components/stream/test_hls.py +++ b/tests/components/stream/test_hls.py @@ -135,7 +135,6 @@ async def test_hls_stream(hass, hls_stream, stream_worker_sync): # Request stream stream.add_provider(HLS_PROVIDER) - assert stream.available stream.start() hls_client = await hls_stream(stream) @@ -162,9 +161,6 @@ async def test_hls_stream(hass, hls_stream, stream_worker_sync): stream_worker_sync.resume() - # The stream worker reported end of stream and exited - assert not stream.available - # Stop stream, if it hasn't quit already stream.stop() @@ -185,7 +181,6 @@ async def test_stream_timeout(hass, hass_client, stream_worker_sync): # Request stream stream.add_provider(HLS_PROVIDER) - assert stream.available stream.start() url = stream.endpoint_url(HLS_PROVIDER) @@ -247,6 +242,7 @@ async def test_stream_keepalive(hass): # Setup demo HLS track source = "test_stream_keepalive_source" stream = create_stream(hass, source, {}) + assert stream.available track = stream.add_provider(HLS_PROVIDER) track.num_segments = 2 @@ -276,6 +272,7 @@ async def test_stream_keepalive(hass): # Stop stream, if it hasn't quit already stream.stop() + assert not stream.available async def test_hls_playlist_view_no_output(hass, hls_stream):