Replace Reolink HDR switch by HDR select entity (#122373)

* Add HDR select * Update strings.json * Update strings.json * add icon * remove HDR switch * cleanup old HDR switch * add tests * Keep HDR switch entity around untill HA 2025.2.0 * Add repair issue * Update strings.json * fixes and review comments * Add tests * Update homeassistant/components/reolink/strings.json Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * Update homeassistant/components/reolink/switch.py Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com> * fixes and simplify --------- Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
2024-07-23 13:28:33 +02:00 · 2024-07-23 13:28:33 +02:00 · 1fd3c9d6dd
commit 1fd3c9d6dd
parent 0d765a27c9
5 changed files with 147 additions and 11 deletions
--- a/tests/components/reolink/test_switch.py
+++ b/tests/components/reolink/test_switch.py
@ -0,0 +1,81 @@
+"""Test the Reolink switch platform."""
+
+from unittest.mock import MagicMock, patch
+
+from homeassistant.components.reolink import const
+from homeassistant.const import Platform
+from homeassistant.core import HomeAssistant
+from homeassistant.helpers import entity_registry as er, issue_registry as ir
+
+from .conftest import TEST_UID
+
+from tests.common import MockConfigEntry
+
+
+async def test_cleanup_hdr_switch_(
+    hass: HomeAssistant,
+    config_entry: MockConfigEntry,
+    reolink_connect: MagicMock,
+    entity_registry: er.EntityRegistry,
+) -> None:
+    """Test cleanup of the HDR switch entity."""
+    original_id = f"{TEST_UID}_hdr"
+    domain = Platform.SWITCH
+
+    reolink_connect.channels = [0]
+    reolink_connect.supported.return_value = True
+
+    entity_registry.async_get_or_create(
+        domain=domain,
+        platform=const.DOMAIN,
+        unique_id=original_id,
+        config_entry=config_entry,
+        suggested_object_id=original_id,
+        disabled_by=er.RegistryEntryDisabler.USER,
+    )
+
+    assert entity_registry.async_get_entity_id(domain, const.DOMAIN, original_id)
+
+    # setup CH 0 and host entities/device
+    with patch("homeassistant.components.reolink.PLATFORMS", [domain]):
+        assert await hass.config_entries.async_setup(config_entry.entry_id)
+    await hass.async_block_till_done()
+
+    assert (
+        entity_registry.async_get_entity_id(domain, const.DOMAIN, original_id) is None
+    )
+
+
+async def test_hdr_switch_deprecated_repair_issue(
+    hass: HomeAssistant,
+    config_entry: MockConfigEntry,
+    reolink_connect: MagicMock,
+    entity_registry: er.EntityRegistry,
+    issue_registry: ir.IssueRegistry,
+) -> None:
+    """Test repairs issue is raised when hdr switch entity used."""
+    original_id = f"{TEST_UID}_hdr"
+    domain = Platform.SWITCH
+
+    reolink_connect.channels = [0]
+    reolink_connect.supported.return_value = True
+
+    entity_registry.async_get_or_create(
+        domain=domain,
+        platform=const.DOMAIN,
+        unique_id=original_id,
+        config_entry=config_entry,
+        suggested_object_id=original_id,
+        disabled_by=None,
+    )
+
+    assert entity_registry.async_get_entity_id(domain, const.DOMAIN, original_id)
+
+    # setup CH 0 and host entities/device
+    with patch("homeassistant.components.reolink.PLATFORMS", [domain]):
+        assert await hass.config_entries.async_setup(config_entry.entry_id)
+    await hass.async_block_till_done()
+
+    assert entity_registry.async_get_entity_id(domain, const.DOMAIN, original_id)
+
+    assert (const.DOMAIN, "hdr_switch_deprecated") in issue_registry.issues