Raise ConditionError for template errors (#46245)

homeassistant/helpers/condition.py

@@ -475,8 +475,7 @@ def async_template(
     try:
         value: str = value_template.async_render(variables, parse_result=False)
     except TemplateError as ex:
-        _LOGGER.error("Error during template condition: %s", ex)
+        raise ConditionError(f"Error in 'template' condition: {ex}") from ex
-        return False
 
     return value.lower() == "true"
 

tests/helpers/test_condition.py

@@ -1,5 +1,5 @@
 """Test the condition helper."""
-from logging import ERROR, WARNING
+from logging import WARNING
 from unittest.mock import patch
 
 import pytest
@@ -1041,19 +1041,14 @@ async def test_extract_devices():
     )
 
 
-async def test_condition_template_error(hass, caplog):
+async def test_condition_template_error(hass):
     """Test invalid template."""
-    caplog.set_level(ERROR)
-
     test = await condition.async_from_config(
         hass, {"condition": "template", "value_template": "{{ undefined.state }}"}
     )
 
-    assert not test(hass)
+    with pytest.raises(ConditionError, match="template"):
-    assert len(caplog.records) == 1
+        test(hass)
-    assert caplog.records[0].message.startswith(
-        "Error during template condition: UndefinedError:"
-    )
 
 
 async def test_condition_template_invalid_results(hass):