Cleanup some async stuff (#6127)

* Cleanup some async stuff

* change to schedule_update_ha_state()

* fix media player

* fix zigbee

homeassistant/components/binary_sensor/envisalink.py

@@ -67,4 +67,4 @@ class EnvisalinkBinarySensor(EnvisalinkDevice, BinarySensorDevice):
     def _update_callback(self, zone):
         """Update the zone's state, if needed."""
         if zone is None or int(zone) == self._zone_number:
-            self.hass.async_add_job(self.update_ha_state)
+            self.hass.schedule_update_ha_state()

homeassistant/components/camera/generic.py

@@ -123,7 +123,7 @@ class GenericCamera(Camera):
                 return self._last_image
             finally:
                 if response is not None:
-                    self.hass.async_add_job(response.release())
+                    yield from response.release()
 
         self._last_url = url
         return self._last_image

homeassistant/components/media_player/universal.py

@@ -151,7 +151,7 @@ class UniversalMediaPlayer(MediaPlayerDevice):
         @callback
         def async_on_dependency_update(*_):
             """Update ha state when dependencies update."""
-            self.hass.add_job(self.async_update_ha_state(True))
+            self.hass.async_add_job(self.async_update_ha_state(True))
 
         depend = copy(children)
         for entity in attributes.values():

homeassistant/components/mqtt/__init__.py

@@ -420,12 +420,13 @@ class MQTT(object):
                                  will_message.get(ATTR_QOS),
                                  will_message.get(ATTR_RETAIN))
 
+    @asyncio.coroutine
     def async_publish(self, topic, payload, qos, retain):
         """Publish a MQTT message.
 
         This method must be run in the event loop and returns a coroutine.
         """
-        return self.hass.loop.run_in_executor(
+        yield from self.hass.loop.run_in_executor(
             None, self._mqttc.publish, topic, payload, qos, retain)
 
     @asyncio.coroutine

homeassistant/components/sensor/envisalink.py

@@ -68,4 +68,4 @@ class EnvisalinkSensor(EnvisalinkDevice):
     def _update_callback(self, partition):
         """Update the partition state in HA, if needed."""
         if partition is None or int(partition) == self._partition_number:
-            self.hass.async_add_job(self.update_ha_state)
+            self.hass.schedule_update_ha_state()

homeassistant/components/sensor/yr.py

@@ -179,7 +179,7 @@ class YrData(object):
 
             finally:
                 if resp is not None:
-                    self.hass.async_add_job(resp.release())
+                    yield from resp.release()
 
             try:
                 import xmltodict

homeassistant/components/sensor/zigbee.py

@@ -55,7 +55,7 @@ class ZigBeeTemperatureSensor(Entity):
         self._config = config
         self._temp = None
         # Get initial state
-        hass.add_job(self.async_update_ha_state, True)
+        self.schedule_update_ha_state(True)
 
     @property
     def name(self):

homeassistant/components/zigbee.py

@@ -307,7 +307,7 @@ class ZigBeeDigitalIn(Entity):
         subscribe(hass, handle_frame)
 
         # Get initial state
-        hass.add_job(self.async_update_ha_state, True)
+        self.schedule_update_ha_state(True)
 
     @property
     def name(self):