evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix incorrect type hint in Filter (#86141)

Browse source
This commit is contained in:
epenet 2023-01-18 12:39:00 +01:00 • committed by GitHub
parent a87a9790e9
commit 1cfcc9313b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 24 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

40
homeassistant/components/filter/sensor.py
View file

@ -400,11 +400,11 @@ class Filter:
def __init__( def __init__(
self, self,
name, name: str,
window_size: int = 1, window_size: int | timedelta,
precision: int | None = None, precision: int,
entity: str | None = None, entity: str,
): ) -> None:
"""Initialize common attributes. """Initialize common attributes.
:param window_size: size of the sliding window that holds previous values :param window_size: size of the sliding window that holds previous values
@ -470,17 +470,17 @@ class RangeFilter(Filter, SensorEntity):
def __init__( def __init__(
self, self,
entity, entity: str,
precision: int | None = DEFAULT_PRECISION, precision: int,
lower_bound: float | None = None, lower_bound: float | None = None,
upper_bound: float | None = None, upper_bound: float | None = None,
): ) -> None:
"""Initialize Filter. """Initialize Filter.
:param upper_bound: band upper bound :param upper_bound: band upper bound
:param lower_bound: band lower bound :param lower_bound: band lower bound
""" """
super().__init__(FILTER_NAME_RANGE, precision=precision, entity=entity) super().__init__(FILTER_NAME_RANGE, DEFAULT_WINDOW_SIZE, precision, entity)
self._lower_bound = lower_bound self._lower_bound = lower_bound
self._upper_bound = upper_bound self._upper_bound = upper_bound
self._stats_internal: Counter = Counter() self._stats_internal: Counter = Counter()
@ -522,7 +522,9 @@ class OutlierFilter(Filter, SensorEntity):
Determines if new state is in a band around the median. Determines if new state is in a band around the median.
""" """
def __init__(self, window_size, precision, entity, radius: float): def __init__(
self, window_size: int, precision: int, entity: str, radius: float
) -> None:
"""Initialize Filter. """Initialize Filter.
:param radius: band radius :param radius: band radius
@ -557,7 +559,9 @@ class OutlierFilter(Filter, SensorEntity):
class LowPassFilter(Filter, SensorEntity): class LowPassFilter(Filter, SensorEntity):
"""BASIC Low Pass Filter.""" """BASIC Low Pass Filter."""
def __init__(self, window_size, precision, entity, time_constant: int): def __init__(
self, window_size: int, precision: int, entity: str, time_constant: int
) -> None:
"""Initialize Filter.""" """Initialize Filter."""
super().__init__(FILTER_NAME_LOWPASS, window_size, precision, entity) super().__init__(FILTER_NAME_LOWPASS, window_size, precision, entity)
self._time_constant = time_constant self._time_constant = time_constant
@ -585,8 +589,12 @@ class TimeSMAFilter(Filter, SensorEntity):
""" """
def __init__( def __init__(
self, window_size, precision, entity, type self,
): # pylint: disable=redefined-builtin window_size: timedelta,
precision: int,
entity: str,
type: str, # pylint: disable=redefined-builtin
) -> None:
"""Initialize Filter. """Initialize Filter.
:param type: type of algorithm used to connect discrete values :param type: type of algorithm used to connect discrete values
@ -594,7 +602,7 @@ class TimeSMAFilter(Filter, SensorEntity):
super().__init__(FILTER_NAME_TIME_SMA, window_size, precision, entity) super().__init__(FILTER_NAME_TIME_SMA, window_size, precision, entity)
self._time_window = window_size self._time_window = window_size
self.last_leak = None self.last_leak = None
self.queue = deque() self.queue = deque[FilterState]()
def _leak(self, left_boundary): def _leak(self, left_boundary):
"""Remove timeouted elements.""" """Remove timeouted elements."""
@ -630,7 +638,7 @@ class ThrottleFilter(Filter, SensorEntity):
One sample per window. One sample per window.
""" """
def __init__(self, window_size, precision, entity): def __init__(self, window_size: int, precision: int, entity: str) -> None:
"""Initialize Filter.""" """Initialize Filter."""
super().__init__(FILTER_NAME_THROTTLE, window_size, precision, entity) super().__init__(FILTER_NAME_THROTTLE, window_size, precision, entity)
self._only_numbers = False self._only_numbers = False
@ -653,7 +661,7 @@ class TimeThrottleFilter(Filter, SensorEntity):
One sample per time period. One sample per time period.
""" """
def __init__(self, window_size, precision, entity): def __init__(self, window_size: timedelta, precision: int, entity: str) -> None:
"""Initialize Filter.""" """Initialize Filter."""
super().__init__(FILTER_NAME_TIME_THROTTLE, window_size, precision, entity) super().__init__(FILTER_NAME_TIME_THROTTLE, window_size, precision, entity)
self._time_window = window_size self._time_window = window_size