evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Print expected device class units in error log (#86125)

Browse source
This commit is contained in:
Joakim Plate 2023-01-25 20:45:50 +01:00 • committed by GitHub
parent 74ae351ac0
commit 1b97a51b5e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
homeassistant/components/sensor/__init__.py
View file

@ -665,6 +665,7 @@ class SensorEntity(Entity):
( (
"Entity %s (%s) is using native unit of measurement '%s' which " "Entity %s (%s) is using native unit of measurement '%s' which "
"is not a valid unit for the device class ('%s') it is using; " "is not a valid unit for the device class ('%s') it is using; "
"expected one of %s; "
"Please update your configuration if your entity is manually " "Please update your configuration if your entity is manually "
"configured, otherwise %s" "configured, otherwise %s"
), ),
@ -672,6 +673,7 @@ class SensorEntity(Entity):
type(self), type(self),
native_unit_of_measurement, native_unit_of_measurement,
device_class, device_class,
[str(unit) if unit else "no unit of measurement" for unit in units],
report_issue, report_issue,
) )

14
tests/components/sensor/test_init.py
View file

@ -9,7 +9,11 @@ import pytest
from pytest import approx from pytest import approx
from homeassistant.components.number import NumberDeviceClass from homeassistant.components.number import NumberDeviceClass
from homeassistant.components.sensor import SensorDeviceClass, SensorStateClass from homeassistant.components.sensor import (
DEVICE_CLASS_UNITS,
SensorDeviceClass,
SensorStateClass,
)
from homeassistant.const import ( from homeassistant.const import (
ATTR_UNIT_OF_MEASUREMENT, ATTR_UNIT_OF_MEASUREMENT,
PERCENTAGE, PERCENTAGE,
@ -1403,13 +1407,17 @@ async def test_device_classes_with_invalid_unit_of_measurement(
device_class=device_class, device_class=device_class,
native_unit_of_measurement="INVALID!", native_unit_of_measurement="INVALID!",
) )
units = [
str(unit) if unit else "no unit of measurement"
for unit in DEVICE_CLASS_UNITS.get(device_class, set())
]
assert await async_setup_component(hass, "sensor", {"sensor": {"platform": "test"}}) assert await async_setup_component(hass, "sensor", {"sensor": {"platform": "test"}})
await hass.async_block_till_done() await hass.async_block_till_done()
assert ( assert (
"is using native unit of measurement 'INVALID!' which is not a valid " "is using native unit of measurement 'INVALID!' which is not a valid "
f"unit for the device class ('{device_class}') it is using" f"unit for the device class ('{device_class}') it is using; "
f"expected one of {units}"
) in caplog.text ) in caplog.text