evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Address late review of switchbot cloud (#102842)

Browse source 
For Martin's review
This commit is contained in:
Ravaka Razafimanantsoa 2023-10-26 19:12:18 +09:00 • committed by GitHub
parent 36c6f426df
commit 1a1bc05470
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
homeassistant/components/switchbot_cloud/climate.py
View file

@ -14,7 +14,6 @@ from homeassistant.config_entries import ConfigEntry
from homeassistant.const import ATTR_TEMPERATURE, UnitOfTemperature from homeassistant.const import ATTR_TEMPERATURE, UnitOfTemperature
from homeassistant.core import HomeAssistant from homeassistant.core import HomeAssistant
from homeassistant.helpers.entity_platform import AddEntitiesCallback from homeassistant.helpers.entity_platform import AddEntitiesCallback
from homeassistant.helpers.typing import DiscoveryInfoType
from . import SwitchbotCloudData from . import SwitchbotCloudData
from .const import DOMAIN from .const import DOMAIN
@ -44,7 +43,6 @@ async def async_setup_entry(
hass: HomeAssistant, hass: HomeAssistant,
config: ConfigEntry, config: ConfigEntry,
async_add_entities: AddEntitiesCallback, async_add_entities: AddEntitiesCallback,
discovery_info: DiscoveryInfoType | None = None,
) -> None: ) -> None:
"""Set up SwitchBot Cloud entry.""" """Set up SwitchBot Cloud entry."""
data: SwitchbotCloudData = hass.data[DOMAIN][config.entry_id] data: SwitchbotCloudData = hass.data[DOMAIN][config.entry_id]
@ -55,7 +53,10 @@ async def async_setup_entry(
class SwitchBotCloudAirConditionner(SwitchBotCloudEntity, ClimateEntity): class SwitchBotCloudAirConditionner(SwitchBotCloudEntity, ClimateEntity):
"""Representation of a SwitchBot air conditionner, as it is an IR device, we don't know the actual state.""" """Representation of a SwitchBot air conditionner.
As it is an IR device, we don't know the actual state.
"""
_attr_assumed_state = True _attr_assumed_state = True
_attr_supported_features = ( _attr_supported_features = (
@ -116,3 +117,4 @@ class SwitchBotCloudAirConditionner(SwitchBotCloudEntity, ClimateEntity):
return return
await self._do_send_command(temperature=temperature) await self._do_send_command(temperature=temperature)
self._attr_target_temperature = temperature self._attr_target_temperature = temperature
self.async_write_ha_state()

2
homeassistant/components/switchbot_cloud/switch.py
View file

@ -7,7 +7,6 @@ from homeassistant.components.switch import SwitchDeviceClass, SwitchEntity
from homeassistant.config_entries import ConfigEntry from homeassistant.config_entries import ConfigEntry
from homeassistant.core import HomeAssistant, callback from homeassistant.core import HomeAssistant, callback
from homeassistant.helpers.entity_platform import AddEntitiesCallback from homeassistant.helpers.entity_platform import AddEntitiesCallback
from homeassistant.helpers.typing import DiscoveryInfoType
from . import SwitchbotCloudData from . import SwitchbotCloudData
from .const import DOMAIN from .const import DOMAIN
@ -19,7 +18,6 @@ async def async_setup_entry(
hass: HomeAssistant, hass: HomeAssistant,
config: ConfigEntry, config: ConfigEntry,
async_add_entities: AddEntitiesCallback, async_add_entities: AddEntitiesCallback,
discovery_info: DiscoveryInfoType | None = None,
) -> None: ) -> None:
"""Set up SwitchBot Cloud entry.""" """Set up SwitchBot Cloud entry."""
data: SwitchbotCloudData = hass.data[DOMAIN][config.entry_id] data: SwitchbotCloudData = hass.data[DOMAIN][config.entry_id]