evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Include webhook_id in mobile_app's notify registration_info (#58007)

Browse source
This commit is contained in:
Zac West 2021-10-18 19:29:13 -07:00 • committed by GitHub
parent 58417f509b
commit 1904019b5f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
homeassistant/components/mobile_app/const.py
View file

@ -49,6 +49,7 @@ ATTR_VERTICAL_ACCURACY = "vertical_accuracy"
ATTR_WEBHOOK_DATA = "data" ATTR_WEBHOOK_DATA = "data"
ATTR_WEBHOOK_ENCRYPTED = "encrypted" ATTR_WEBHOOK_ENCRYPTED = "encrypted"
ATTR_WEBHOOK_ENCRYPTED_DATA = "encrypted_data" ATTR_WEBHOOK_ENCRYPTED_DATA = "encrypted_data"
ATTR_WEBHOOK_ID = "webhook_id"
ATTR_WEBHOOK_TYPE = "type" ATTR_WEBHOOK_TYPE = "type"
ERR_ENCRYPTION_ALREADY_ENABLED = "encryption_already_enabled" ERR_ENCRYPTION_ALREADY_ENABLED = "encryption_already_enabled"

2
homeassistant/components/mobile_app/notify.py
View file

@ -36,6 +36,7 @@ from .const import (
ATTR_PUSH_RATE_LIMITS_SUCCESSFUL, ATTR_PUSH_RATE_LIMITS_SUCCESSFUL,
ATTR_PUSH_TOKEN, ATTR_PUSH_TOKEN,
ATTR_PUSH_URL, ATTR_PUSH_URL,
ATTR_WEBHOOK_ID,
DATA_CONFIG_ENTRIES, DATA_CONFIG_ENTRIES,
DATA_NOTIFY, DATA_NOTIFY,
DATA_PUSH_CHANNEL, DATA_PUSH_CHANNEL,
@ -147,6 +148,7 @@ class MobileAppNotificationService(BaseNotificationService):
reg_info = { reg_info = {
ATTR_APP_ID: entry_data[ATTR_APP_ID], ATTR_APP_ID: entry_data[ATTR_APP_ID],
ATTR_APP_VERSION: entry_data[ATTR_APP_VERSION], ATTR_APP_VERSION: entry_data[ATTR_APP_VERSION],
ATTR_WEBHOOK_ID: target,
} }
if ATTR_OS_VERSION in entry_data: if ATTR_OS_VERSION in entry_data:
reg_info[ATTR_OS_VERSION] = entry_data[ATTR_OS_VERSION] reg_info[ATTR_OS_VERSION] = entry_data[ATTR_OS_VERSION]

1
tests/components/mobile_app/test_notify.py
View file

@ -118,6 +118,7 @@ async def test_notify_works(hass, aioclient_mock, setup_push_receiver):
assert call_json["message"] == "Hello world" assert call_json["message"] == "Hello world"
assert call_json["registration_info"]["app_id"] == "io.homeassistant.mobile_app" assert call_json["registration_info"]["app_id"] == "io.homeassistant.mobile_app"
assert call_json["registration_info"]["app_version"] == "1.0" assert call_json["registration_info"]["app_version"] == "1.0"
assert call_json["registration_info"]["webhook_id"] == "mock-webhook_id"
async def test_notify_ws_works( async def test_notify_ws_works(