From 1608e05be6762e8adfaaa4a00e32fc52d7e38f2f Mon Sep 17 00:00:00 2001
From: "J. Nick Koston" <nick@koston.org>
Date: Fri, 16 Feb 2024 00:41:55 -0600
Subject: [PATCH] Speed up registry config websocket api calls with list comps
 (#110693)

* Speed up registry config websocket api calls with list comps

list comps are faster than generator expressions, even more so in
python 3.12 since https://peps.python.org/pep-0709/

https://stackoverflow.com/questions/47789/generator-expressions-vs-list-comprehensions/62709748#62709748

* more readable
---
 .../components/config/device_registry.py       |  9 ++++-----
 .../components/config/entity_registry.py       | 18 ++++++++----------
 2 files changed, 12 insertions(+), 15 deletions(-)

diff --git a/homeassistant/components/config/device_registry.py b/homeassistant/components/config/device_registry.py
index dfa55b02c30..aa861a515fd 100644
--- a/homeassistant/components/config/device_registry.py
+++ b/homeassistant/components/config/device_registry.py
@@ -47,15 +47,14 @@ def websocket_list_devices(
         f'"success":true,"result": ['
     ).encode()
     # Concatenate cached entity registry item JSON serializations
-    msg_json = (
-        msg_json_prefix
-        + b",".join(
+    inner = b",".join(
+        [
             entry.json_repr
             for entry in registry.devices.values()
             if entry.json_repr is not None
-        )
-        + b"]}"
+        ]
     )
+    msg_json = b"".join((msg_json_prefix, inner, b"]}"))
     connection.send_message(msg_json)
 
 
diff --git a/homeassistant/components/config/entity_registry.py b/homeassistant/components/config/entity_registry.py
index f1c1fadc144..11a4617adfa 100644
--- a/homeassistant/components/config/entity_registry.py
+++ b/homeassistant/components/config/entity_registry.py
@@ -45,15 +45,14 @@ def websocket_list_entities(
         '"success":true,"result": ['
     ).encode()
     # Concatenate cached entity registry item JSON serializations
-    msg_json = (
-        msg_json_prefix
-        + b",".join(
+    inner = b",".join(
+        [
             entry.partial_json_repr
             for entry in registry.entities.values()
             if entry.partial_json_repr is not None
-        )
-        + b"]}"
+        ]
     )
+    msg_json = b"".join((msg_json_prefix, inner, b"]}"))
     connection.send_message(msg_json)
 
 
@@ -77,15 +76,14 @@ def websocket_list_entities_for_display(
         f'"result":{{"entity_categories":{_ENTITY_CATEGORIES_JSON},"entities":['
     ).encode()
     # Concatenate cached entity registry item JSON serializations
-    msg_json = (
-        msg_json_prefix
-        + b",".join(
+    inner = b",".join(
+        [
             entry.display_json_repr
             for entry in registry.entities.values()
             if entry.disabled_by is None and entry.display_json_repr is not None
-        )
-        + b"]}}"
+        ]
     )
+    msg_json = b"".join((msg_json_prefix, inner, b"]}}"))
     connection.send_message(msg_json)