evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Move unused function in withings (#84089)

Browse source 
* Remove unused function in withings

* Move to tests

* Remove reference to attribute.platform

* Move WITHINGS_MEASUREMENTS_MAP to tests

* measute_type > measure_type

* One more
This commit is contained in:
epenet 2022-12-16 10:50:20 +01:00 • committed by GitHub
parent 7f3f271a59
commit 14ee3f1ddc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 65 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

36
tests/components/withings/test_sensor.py
View file

@ -17,10 +17,10 @@ from withings_api.common import (
SleepModel,
)
from homeassistant.components.sensor import DOMAIN as SENSOR_DOMAIN
from homeassistant.components.withings.common import (
WITHINGS_MEASUREMENTS_MAP,
WITHINGS_ATTRIBUTES,
WithingsAttribute,
async_get_entity_id,
get_platform_attributes,
)
from homeassistant.components.withings.const import Measurement
@ -30,7 +30,13 @@ from homeassistant.helpers import entity_registry as er
from homeassistant.helpers.entity_registry import EntityRegistry
from homeassistant.util import dt as dt_util
from .common import ComponentFactory, new_profile_config
from .common import ComponentFactory, async_get_entity_id, new_profile_config
WITHINGS_MEASUREMENTS_MAP: dict[Measurement, WithingsAttribute] = {
attr.measurement: attr
for attr in WITHINGS_ATTRIBUTES
if attr.platform == SENSOR_DOMAIN
}
PERSON0 = new_profile_config(
"person0",
@ -311,14 +317,18 @@ async def test_sensor_default_enabled_entities(
# Assert entities should not exist yet.
for attribute in get_platform_attributes(Platform.SENSOR):
assert not await async_get_entity_id(hass, attribute, PERSON0.user_id)
assert not await async_get_entity_id(
hass, attribute, PERSON0.user_id, SENSOR_DOMAIN
)
# person 0
await component_factory.setup_profile(PERSON0.user_id)
# Assert entities should exist.
for attribute in get_platform_attributes(Platform.SENSOR):
entity_id = await async_get_entity_id(hass, attribute, PERSON0.user_id)
entity_id = await async_get_entity_id(
hass, attribute, PERSON0.user_id, SENSOR_DOMAIN
)
assert entity_id
assert entity_registry.async_is_registered(entity_id)
@ -330,7 +340,9 @@ async def test_sensor_default_enabled_entities(
for person, measurement, expected in EXPECTED_DATA:
attribute = WITHINGS_MEASUREMENTS_MAP[measurement]
entity_id = await async_get_entity_id(hass, attribute, person.user_id)
entity_id = await async_get_entity_id(
hass, attribute, person.user_id, SENSOR_DOMAIN
)
state_obj = hass.states.get(entity_id)
if attribute.enabled_by_default:
@ -357,14 +369,18 @@ async def test_all_entities(
# Assert entities should not exist yet.
for attribute in get_platform_attributes(Platform.SENSOR):
assert not await async_get_entity_id(hass, attribute, PERSON0.user_id)
assert not await async_get_entity_id(
hass, attribute, PERSON0.user_id, SENSOR_DOMAIN
)
# person 0
await component_factory.setup_profile(PERSON0.user_id)
# Assert entities should exist.
for attribute in get_platform_attributes(Platform.SENSOR):
entity_id = await async_get_entity_id(hass, attribute, PERSON0.user_id)
entity_id = await async_get_entity_id(
hass, attribute, PERSON0.user_id, SENSOR_DOMAIN
)
assert entity_id
assert entity_registry.async_is_registered(entity_id)
@ -376,7 +392,9 @@ async def test_all_entities(
for person, measurement, expected in EXPECTED_DATA:
attribute = WITHINGS_MEASUREMENTS_MAP[measurement]
entity_id = await async_get_entity_id(hass, attribute, person.user_id)
entity_id = await async_get_entity_id(
hass, attribute, person.user_id, SENSOR_DOMAIN
)
state_obj = hass.states.get(entity_id)
async_assert_state_equals(entity_id, state_obj, expected, attribute)