evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Exclude update entity picture attribute from recorder (#69201)

Browse source
This commit is contained in:
Franck Nijhof 2022-04-03 21:41:51 +02:00 • committed by GitHub
parent cf685ef651
commit 14a19aea03
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
homeassistant/components/update/recorder.py
View file

@ -1,12 +1,13 @@
"""Integration platform for recorder.""" """Integration platform for recorder."""
from __future__ import annotations from __future__ import annotations
from homeassistant.const import ATTR_ENTITY_PICTURE
from homeassistant.core import HomeAssistant, callback from homeassistant.core import HomeAssistant, callback
from . import ATTR_IN_PROGRESS, ATTR_RELEASE_SUMMARY from .const import ATTR_IN_PROGRESS, ATTR_RELEASE_SUMMARY
@callback @callback
def exclude_attributes(hass: HomeAssistant) -> set[str]: def exclude_attributes(hass: HomeAssistant) -> set[str]:
"""Exclude large and chatty update attributes from being recorded in the database.""" """Exclude large and chatty update attributes from being recorded in the database."""
return {ATTR_IN_PROGRESS, ATTR_RELEASE_SUMMARY} return {ATTR_ENTITY_PICTURE, ATTR_IN_PROGRESS, ATTR_RELEASE_SUMMARY}

7
tests/components/update/test_recorder.py
View file

@ -11,7 +11,7 @@ from homeassistant.components.update.const import (
ATTR_RELEASE_SUMMARY, ATTR_RELEASE_SUMMARY,
DOMAIN, DOMAIN,
) )
from homeassistant.const import CONF_PLATFORM from homeassistant.const import ATTR_ENTITY_PICTURE, CONF_PLATFORM
from homeassistant.core import HomeAssistant, State from homeassistant.core import HomeAssistant, State
from homeassistant.setup import async_setup_component from homeassistant.setup import async_setup_component
from homeassistant.util import dt as dt_util from homeassistant.util import dt as dt_util
@ -31,6 +31,10 @@ async def test_exclude_attributes(
await hass.async_block_till_done() await hass.async_block_till_done()
state = hass.states.get("update.update_already_in_progress") state = hass.states.get("update.update_already_in_progress")
assert state.attributes[ATTR_IN_PROGRESS] == 50 assert state.attributes[ATTR_IN_PROGRESS] == 50
assert (
state.attributes[ATTR_ENTITY_PICTURE]
== "https://brands.home-assistant.io/_/test/icon.png"
)
await async_setup_component(hass, DOMAIN, {}) await async_setup_component(hass, DOMAIN, {})
await hass.async_block_till_done() await hass.async_block_till_done()
@ -50,6 +54,7 @@ async def test_exclude_attributes(
states: list[State] = await hass.async_add_executor_job(_fetch_states) states: list[State] = await hass.async_add_executor_job(_fetch_states)
assert len(states) > 1 assert len(states) > 1
for state in states: for state in states:
assert ATTR_ENTITY_PICTURE not in state.attributes
assert ATTR_IN_PROGRESS not in state.attributes assert ATTR_IN_PROGRESS not in state.attributes
assert ATTR_RELEASE_SUMMARY not in state.attributes assert ATTR_RELEASE_SUMMARY not in state.attributes
assert ATTR_INSTALLED_VERSION in state.attributes assert ATTR_INSTALLED_VERSION in state.attributes