From 148860587cf2213df4612fe21cde94a06c193459 Mon Sep 17 00:00:00 2001 From: Anders Melchiorsen Date: Sat, 27 Apr 2019 18:16:44 +0200 Subject: [PATCH] No longer promote imports inside methods (#23471) --- .github/PULL_REQUEST_TEMPLATE.md | 2 -- script/gen_requirements_all.py | 1 - 2 files changed, 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ebebf487275..b91540c5f8e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -25,7 +25,6 @@ If user exposed functionality or configuration variables are added/changed: If the code communicates with devices, web services, or third-party tools: - [ ] [_The manifest file_][manifest-docs] has all fields filled out correctly ([example][ex-manifest]). - [ ] New dependencies have been added to `requirements` in the manifest ([example][ex-requir]). - - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]). - [ ] New or updated dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`. - [ ] New files were added to `.coveragerc`. @@ -34,5 +33,4 @@ If the code does not interact with devices: [ex-manifest]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/mobile_app/manifest.json [ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/mobile_app/manifest.json#L5 -[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard/__init__.py#L23 [manifest-docs]: https://developers.home-assistant.io/docs/en/development_checklist.html#_the-manifest-file_ diff --git a/script/gen_requirements_all.py b/script/gen_requirements_all.py index 9586dc17947..dc8ed652d11 100755 --- a/script/gen_requirements_all.py +++ b/script/gen_requirements_all.py @@ -232,7 +232,6 @@ def gather_modules(): if errors: print("******* ERROR") print("Errors while importing: ", ', '.join(errors)) - print("Make sure you import 3rd party libraries inside methods.") return None return reqs