evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove unnecessary try-else (3) (#86160)

Browse source
This commit is contained in:
Marc Mueller 2023-01-18 14:25:28 +01:00 • committed by GitHub
parent bc115634d1
commit 141acba40d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 35 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

2
homeassistant/components/kostal_plenticore/helper.py
View file

@ -145,7 +145,7 @@ class DataUpdateCoordinatorMixin:
await client.set_setting_values(module_id, value)
except ApiException:
return False
else:
return True

6
homeassistant/components/media_extractor/__init__.py
View file

@ -140,7 +140,7 @@ class MediaExtractor:
except MEQueryException:
_LOGGER.error("Wrong query format: %s", stream_query)
return
else:
data = {k: v for k, v in self.call_data.items() if k != ATTR_ENTITY_ID}
data[ATTR_MEDIA_CONTENT_ID] = stream_url
@ -148,9 +148,7 @@ class MediaExtractor:
data[ATTR_ENTITY_ID] = entity_id
self.hass.async_create_task(
self.hass.services.async_call(
MEDIA_PLAYER_DOMAIN, SERVICE_PLAY_MEDIA, data
)
self.hass.services.async_call(MEDIA_PLAYER_DOMAIN, SERVICE_PLAY_MEDIA, data)
)
def get_stream_query_for_entity(self, entity_id):

2
homeassistant/components/metoffice/helpers.py
View file

@ -35,7 +35,7 @@ def fetch_data(connection: datapoint.Manager, site: Site, mode: str) -> MetOffic
except (ValueError, datapoint.exceptions.APIException) as err:
_LOGGER.error("Check Met Office connection: %s", err.args)
raise UpdateFailed from err
else:
time_now = utcnow()
return MetOfficeData(
now=forecast.now(),

2
homeassistant/components/modbus/modbus.py
View file

@ -371,7 +371,7 @@ class ModbusHub:
except ModbusException as exception_error:
self._log_error(str(exception_error), error_state=False)
return False
else:
message = f"modbus {self.name} communication open"
_LOGGER.info(message)
return True

2
homeassistant/components/modem_callerid/config_flow.py
View file

@ -111,5 +111,5 @@ class PhoneModemFlowHandler(config_entries.ConfigFlow, domain=DOMAIN):
await api.test(dev_path)
except EXCEPTIONS:
return {"base": "cannot_connect"}
else:
return None

4
homeassistant/components/motion_blinds/__init__.py
View file

@ -71,7 +71,7 @@ class DataUpdateCoordinatorMotionBlinds(DataUpdateCoordinator):
except (timeout, ParseException):
# let the error be logged and handled by the motionblinds library
return {ATTR_AVAILABLE: False}
else:
return {ATTR_AVAILABLE: True}
def update_blind(self, blind):
@ -84,7 +84,7 @@ class DataUpdateCoordinatorMotionBlinds(DataUpdateCoordinator):
except (timeout, ParseException):
# let the error be logged and handled by the motionblinds library
return {ATTR_AVAILABLE: False}
else:
return {ATTR_AVAILABLE: True}
async def _async_update_data(self):