evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Migrate Tailscale to new entity naming style (#75018)

Browse source
This commit is contained in:
Franck Nijhof 2022-07-16 15:21:19 +02:00 • committed by GitHub
parent 027cdbdb38
commit 13cea26e74
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
homeassistant/components/tailscale/__init__.py
View file

@ -41,6 +41,8 @@ async def async_unload_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool:
class TailscaleEntity(CoordinatorEntity): class TailscaleEntity(CoordinatorEntity):
"""Defines a Tailscale base entity.""" """Defines a Tailscale base entity."""
_attr_has_entity_name = True
def __init__( def __init__(
self, self,
*, *,
@ -52,8 +54,6 @@ class TailscaleEntity(CoordinatorEntity):
super().__init__(coordinator=coordinator) super().__init__(coordinator=coordinator)
self.entity_description = description self.entity_description = description
self.device_id = device.device_id self.device_id = device.device_id
self.friendly_name = device.name.split(".")[0]
self._attr_name = f"{self.friendly_name} {description.name}"
self._attr_unique_id = f"{device.device_id}_{description.key}" self._attr_unique_id = f"{device.device_id}_{description.key}"
@property @property
@ -71,6 +71,6 @@ class TailscaleEntity(CoordinatorEntity):
identifiers={(DOMAIN, device.device_id)}, identifiers={(DOMAIN, device.device_id)},
manufacturer="Tailscale Inc.", manufacturer="Tailscale Inc.",
model=device.os, model=device.os,
name=self.friendly_name, name=device.name.split(".")[0],
sw_version=device.client_version, sw_version=device.client_version,
) )

2
homeassistant/components/tailscale/binary_sensor.py
View file

@ -44,7 +44,7 @@ BINARY_SENSORS: tuple[TailscaleBinarySensorEntityDescription, ...] = (
), ),
TailscaleBinarySensorEntityDescription( TailscaleBinarySensorEntityDescription(
key="client_supports_hair_pinning", key="client_supports_hair_pinning",
name="Supports Hairpinning", name="Supports hairpinning",
icon="mdi:wan", icon="mdi:wan",
entity_category=EntityCategory.DIAGNOSTIC, entity_category=EntityCategory.DIAGNOSTIC,
is_on_fn=lambda device: device.client_connectivity.client_supports.hair_pinning, is_on_fn=lambda device: device.client_connectivity.client_supports.hair_pinning,

4
homeassistant/components/tailscale/sensor.py
View file

@ -45,14 +45,14 @@ SENSORS: tuple[TailscaleSensorEntityDescription, ...] = (
), ),
TailscaleSensorEntityDescription( TailscaleSensorEntityDescription(
key="ip", key="ip",
name="IP Address", name="IP address",
icon="mdi:ip-network", icon="mdi:ip-network",
entity_category=EntityCategory.DIAGNOSTIC, entity_category=EntityCategory.DIAGNOSTIC,
value_fn=lambda device: device.addresses[0] if device.addresses else None, value_fn=lambda device: device.addresses[0] if device.addresses else None,
), ),
TailscaleSensorEntityDescription( TailscaleSensorEntityDescription(
key="last_seen", key="last_seen",
name="Last Seen", name="Last seen",
device_class=SensorDeviceClass.TIMESTAMP, device_class=SensorDeviceClass.TIMESTAMP,
value_fn=lambda device: device.last_seen, value_fn=lambda device: device.last_seen,
), ),

2
tests/components/tailscale/test_binary_sensor.py
View file

@ -43,7 +43,7 @@ async def test_tailscale_binary_sensors(
assert state.state == STATE_OFF assert state.state == STATE_OFF
assert ( assert (
state.attributes.get(ATTR_FRIENDLY_NAME) state.attributes.get(ATTR_FRIENDLY_NAME)
== "frencks-iphone Supports Hairpinning" == "frencks-iphone Supports hairpinning"
) )
assert state.attributes.get(ATTR_ICON) == "mdi:wan" assert state.attributes.get(ATTR_ICON) == "mdi:wan"
assert ATTR_DEVICE_CLASS not in state.attributes assert ATTR_DEVICE_CLASS not in state.attributes

4
tests/components/tailscale/test_sensor.py
View file

@ -35,7 +35,7 @@ async def test_tailscale_sensors(
assert entry.unique_id == "123457_last_seen" assert entry.unique_id == "123457_last_seen"
assert entry.entity_category is None assert entry.entity_category is None
assert state.state == "2021-11-15T20:37:03+00:00" assert state.state == "2021-11-15T20:37:03+00:00"
assert state.attributes.get(ATTR_FRIENDLY_NAME) == "router Last Seen" assert state.attributes.get(ATTR_FRIENDLY_NAME) == "router Last seen"
assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.TIMESTAMP assert state.attributes.get(ATTR_DEVICE_CLASS) == SensorDeviceClass.TIMESTAMP
assert ATTR_ICON not in state.attributes assert ATTR_ICON not in state.attributes
@ -46,7 +46,7 @@ async def test_tailscale_sensors(
assert entry.unique_id == "123457_ip" assert entry.unique_id == "123457_ip"
assert entry.entity_category == EntityCategory.DIAGNOSTIC assert entry.entity_category == EntityCategory.DIAGNOSTIC
assert state.state == "100.11.11.112" assert state.state == "100.11.11.112"
assert state.attributes.get(ATTR_FRIENDLY_NAME) == "router IP Address" assert state.attributes.get(ATTR_FRIENDLY_NAME) == "router IP address"
assert state.attributes.get(ATTR_ICON) == "mdi:ip-network" assert state.attributes.get(ATTR_ICON) == "mdi:ip-network"
assert ATTR_DEVICE_CLASS not in state.attributes assert ATTR_DEVICE_CLASS not in state.attributes