From 10e43048bd7698d569a8bf3d5ab46c6604456ae2 Mon Sep 17 00:00:00 2001 From: Joost Lekkerkerker Date: Wed, 4 Oct 2023 16:45:13 +0200 Subject: [PATCH] Fix Withings translations (#101397) --- homeassistant/components/withings/sensor.py | 5 ++--- homeassistant/components/withings/strings.json | 3 +++ tests/components/withings/snapshots/test_sensor.ambr | 8 ++++---- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/homeassistant/components/withings/sensor.py b/homeassistant/components/withings/sensor.py index 42f5ac18f2f..77a706dc55d 100644 --- a/homeassistant/components/withings/sensor.py +++ b/homeassistant/components/withings/sensor.py @@ -240,8 +240,7 @@ SENSORS = [ key=Measurement.SLEEP_HEART_RATE_MAX.value, measurement=Measurement.SLEEP_HEART_RATE_MAX, measure_type=GetSleepSummaryField.HR_MAX, - translation_key="fat_mass", - name="Maximum heart rate", + translation_key="maximum_heart_rate", native_unit_of_measurement=UOM_BEATS_PER_MINUTE, icon="mdi:heart-pulse", state_class=SensorStateClass.MEASUREMENT, @@ -251,7 +250,7 @@ SENSORS = [ key=Measurement.SLEEP_HEART_RATE_MIN.value, measurement=Measurement.SLEEP_HEART_RATE_MIN, measure_type=GetSleepSummaryField.HR_MIN, - translation_key="maximum_heart_rate", + translation_key="minimum_heart_rate", native_unit_of_measurement=UOM_BEATS_PER_MINUTE, icon="mdi:heart-pulse", state_class=SensorStateClass.MEASUREMENT, diff --git a/homeassistant/components/withings/strings.json b/homeassistant/components/withings/strings.json index ea925f535e3..df948a2b593 100644 --- a/homeassistant/components/withings/strings.json +++ b/homeassistant/components/withings/strings.json @@ -89,6 +89,9 @@ "maximum_heart_rate": { "name": "Maximum heart rate" }, + "minimum_heart_rate": { + "name": "Minimum heart rate" + }, "light_sleep": { "name": "Light sleep" }, diff --git a/tests/components/withings/snapshots/test_sensor.ambr b/tests/components/withings/snapshots/test_sensor.ambr index 6aa9e5b3784..9733880b03a 100644 --- a/tests/components/withings/snapshots/test_sensor.ambr +++ b/tests/components/withings/snapshots/test_sensor.ambr @@ -211,13 +211,13 @@ # name: test_all_entities.21 StateSnapshot({ 'attributes': ReadOnlyDict({ - 'friendly_name': 'henk Fat mass', + 'friendly_name': 'henk Maximum heart rate', 'icon': 'mdi:heart-pulse', 'state_class': , 'unit_of_measurement': 'bpm', }), 'context': , - 'entity_id': 'sensor.henk_fat_mass_2', + 'entity_id': 'sensor.henk_maximum_heart_rate', 'last_changed': , 'last_updated': , 'state': '165.0', @@ -226,13 +226,13 @@ # name: test_all_entities.22 StateSnapshot({ 'attributes': ReadOnlyDict({ - 'friendly_name': 'henk Maximum heart rate', + 'friendly_name': 'henk Minimum heart rate', 'icon': 'mdi:heart-pulse', 'state_class': , 'unit_of_measurement': 'bpm', }), 'context': , - 'entity_id': 'sensor.henk_maximum_heart_rate', + 'entity_id': 'sensor.henk_minimum_heart_rate', 'last_changed': , 'last_updated': , 'state': '166.0',