evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Prevent accidentally reusing an entity object (#102911)

Browse source 
* Prevent accidentally reusing an entity object

* Fix group reload service

* Revert "Fix group reload service"

* Improve test

* Add tests aserting entity can't be reused
This commit is contained in:
Erik Montnemery 2023-11-03 21:01:38 +01:00 • committed by GitHub
parent dca72c598e
commit 0ea0a1ed06
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 85 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

32
tests/helpers/test_entity_platform.py
View file

@ -565,24 +565,32 @@ async def test_async_remove_with_platform_update_finishes(hass: HomeAssistant) -
component = EntityComponent(_LOGGER, DOMAIN, hass)
await component.async_setup({})
entity1 = MockEntity(name="test_1")
entity2 = MockEntity(name="test_1")
async def _delayed_update(*args, **kwargs):
await asyncio.sleep(0.01)
update_called.set()
await update_done.wait()
entity1.async_update = _delayed_update
entity2.async_update = _delayed_update
# Add, remove, add, remove and make sure no updates
# cause the entity to reappear after removal
for _ in range(2):
await component.async_add_entities([entity1])
assert len(hass.states.async_entity_ids()) == 1
entity1.async_write_ha_state()
assert hass.states.get(entity1.entity_id) is not None
task = asyncio.create_task(entity1.async_update_ha_state(True))
await entity1.async_remove()
assert len(hass.states.async_entity_ids()) == 0
# Add, remove, and make sure no updates
# cause the entity to reappear after removal and
# that we can add another entity with the same entity_id
for entity in [entity1, entity2]:
update_called = asyncio.Event()
update_done = asyncio.Event()
await component.async_add_entities([entity])
assert hass.states.async_entity_ids() == ["test_domain.test_1"]
entity.async_write_ha_state()
assert hass.states.get(entity.entity_id) is not None
task = asyncio.create_task(entity.async_update_ha_state(True))
await update_called.wait()
await entity.async_remove()
assert hass.states.async_entity_ids() == []
update_done.set()
await task
assert len(hass.states.async_entity_ids()) == 0
assert hass.states.async_entity_ids() == []
async def test_not_adding_duplicate_entities_with_unique_id(