From 0e1cc0518903311b4b64b46907a6cda10b5dd39d Mon Sep 17 00:00:00 2001 From: tschmidty69 Date: Fri, 19 Jan 2018 01:01:04 -0500 Subject: [PATCH] Snips: (change) Removed unknown intent speech response (#11776) * Removed unknown intent speech response * Fixed tests, doh! * Woof --- homeassistant/components/snips.py | 1 - tests/components/test_snips.py | 32 +++++++++---------------------- 2 files changed, 9 insertions(+), 24 deletions(-) diff --git a/homeassistant/components/snips.py b/homeassistant/components/snips.py index d221c8512c6..5a317b09e87 100644 --- a/homeassistant/components/snips.py +++ b/homeassistant/components/snips.py @@ -104,7 +104,6 @@ def async_setup(hass, config): except intent.UnknownIntent as err: _LOGGER.warning("Received unknown intent %s", request['intent']['intentName']) - snips_response = "Unknown Intent" except intent.IntentError: _LOGGER.exception("Error while handling intent: %s.", intent_type) snips_response = "Error while handling intent" diff --git a/tests/components/test_snips.py b/tests/components/test_snips.py index 711d13dc341..f37beef7960 100644 --- a/tests/components/test_snips.py +++ b/tests/components/test_snips.py @@ -1,6 +1,7 @@ """Test the Snips component.""" import asyncio import json +import logging from homeassistant.core import callback from homeassistant.bootstrap import async_setup_component @@ -151,42 +152,27 @@ def test_intent_speech_response(hass, mqtt_mock): @asyncio.coroutine -def test_snips_unknown_intent(hass, mqtt_mock): - """Test calling unknown Intent via Snips.""" - event = 'call_service' - events = [] - - @callback - def record_event(event): - """Add recorded event to set.""" - events.append(event) +def test_unknown_intent(hass, mqtt_mock, caplog): + """Test unknown intent.""" + caplog.set_level(logging.WARNING) result = yield from async_setup_component(hass, "snips", { "snips": {}, }) assert result payload = """ { - "input": "what to do", + "input": "I don't know what I am supposed to do", + "sessionId": "abcdef1234567890", "intent": { "intentName": "unknownIntent" }, "slots": [] } """ - intents = async_mock_intent(hass, 'knownIntent') - hass.bus.async_listen(event, record_event) - async_fire_mqtt_message(hass, 'hermes/intent/unknownIntent', - payload) + async_fire_mqtt_message(hass, + 'hermes/intent/unknownIntent', payload) yield from hass.async_block_till_done() - - assert not intents - assert len(events) == 1 - assert events[0].data['domain'] == 'mqtt' - assert events[0].data['service'] == 'publish' - payload = json.loads(events[0].data['service_data']['payload']) - topic = events[0].data['service_data']['topic'] - assert payload['text'] == 'Unknown Intent' - assert topic == 'hermes/dialogueManager/endSession' + assert 'Received unknown intent unknownIntent' in caplog.text @asyncio.coroutine