evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Speed up logger setup (#114610)

Browse source 
* Speed up logger setup

Preload core.logger and avoid saving it
until after startup

* add comment about 180s

* Adjust grammar

---------

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
This commit is contained in:
J. Nick Koston 2024-04-03 20:35:44 -10:00 • committed by GitHub
parent 7a2e529bb7
commit 0c3ccabfb1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 28 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

16
homeassistant/components/logger/helpers.py
View file

@ -28,6 +28,16 @@ from .const import (
STORAGE_VERSION,
)
SAVE_DELAY = 15.0
# At startup, we want to save after a long delay to avoid
# saving while the system is still starting up. If the system
# for some reason restarts quickly, it will still be written
# at the final write event. In most cases we expect startup
# to happen in less than 180 seconds, but if it takes longer
# it's likely delayed because of remote I/O and not local
# I/O so it's fine to save at that point.
SAVE_DELAY_LONG = 180.0
@callback
def async_get_domain_config(hass: HomeAssistant) -> LoggerDomainConfig:
@ -148,7 +158,7 @@ class LoggerSettings:
for domain, settings in stored_log_config.items()
}
}
await self._store.async_save(self._async_data_to_save())
self.async_save(SAVE_DELAY_LONG)
@callback
def _async_data_to_save(self) -> dict[str, dict[str, dict[str, str]]]:
@ -164,9 +174,9 @@ class LoggerSettings:
}
@callback
def async_save(self) -> None:
def async_save(self, delay: float = SAVE_DELAY) -> None:
"""Save settings."""
self._store.async_delay_save(self._async_data_to_save, 15)
self._store.async_delay_save(self._async_data_to_save, delay)
@callback
def _async_get_logger_logs(self) -> dict[str, int]: