evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Only set fan state in ecobee set_fan_mode service (#48086)

Browse source
This commit is contained in:
Brent Petit 2021-04-18 15:35:03 -05:00 • committed by GitHub
parent 04a0ca14e0
commit 080c89c761
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

5
homeassistant/components/ecobee/climate.py
View file

@ -644,14 +644,11 @@ class Thermostat(ClimateEntity):
_LOGGER.error(error) _LOGGER.error(error)
return return
cool_temp = self.thermostat["runtime"]["desiredCool"] / 10.0
heat_temp = self.thermostat["runtime"]["desiredHeat"] / 10.0
self.data.ecobee.set_fan_mode( self.data.ecobee.set_fan_mode(
self.thermostat_index, self.thermostat_index,
fan_mode, fan_mode,
cool_temp,
heat_temp,
self.hold_preference(), self.hold_preference(),
holdHours=self.hold_hours(),
) )
_LOGGER.info("Setting fan mode to: %s", fan_mode) _LOGGER.info("Setting fan mode to: %s", fan_mode)

2
homeassistant/components/ecobee/manifest.json
View file

@ -3,7 +3,7 @@
"name": "ecobee", "name": "ecobee",
"config_flow": true, "config_flow": true,
"documentation": "https://www.home-assistant.io/integrations/ecobee", "documentation": "https://www.home-assistant.io/integrations/ecobee",
"requirements": ["python-ecobee-api==0.2.10"], "requirements": ["python-ecobee-api==0.2.11"],
"codeowners": ["@marthoc"], "codeowners": ["@marthoc"],
"iot_class": "cloud_polling" "iot_class": "cloud_polling"
} }

2
requirements_all.txt
View file

@ -1771,7 +1771,7 @@ python-clementine-remote==1.0.1
python-digitalocean==1.13.2 python-digitalocean==1.13.2
# homeassistant.components.ecobee # homeassistant.components.ecobee
python-ecobee-api==0.2.10 python-ecobee-api==0.2.11
# homeassistant.components.eq3btsmart # homeassistant.components.eq3btsmart
# python-eq3bt==0.1.11 # python-eq3bt==0.1.11

2
requirements_test_all.txt
View file

@ -962,7 +962,7 @@ pysqueezebox==0.5.5
pysyncthru==0.7.0 pysyncthru==0.7.0
# homeassistant.components.ecobee # homeassistant.components.ecobee
python-ecobee-api==0.2.10 python-ecobee-api==0.2.11
# homeassistant.components.darksky # homeassistant.components.darksky
python-forecastio==1.4.0 python-forecastio==1.4.0

4
tests/components/ecobee/test_climate.py
View file

@ -320,7 +320,7 @@ async def test_set_fan_mode_on(thermostat, data):
data.reset_mock() data.reset_mock()
thermostat.set_fan_mode("on") thermostat.set_fan_mode("on")
data.ecobee.set_fan_mode.assert_has_calls( data.ecobee.set_fan_mode.assert_has_calls(
[mock.call(1, "on", 20, 40, "nextTransition")] [mock.call(1, "on", "nextTransition", holdHours=None)]
) )
@ -329,5 +329,5 @@ async def test_set_fan_mode_auto(thermostat, data):
data.reset_mock() data.reset_mock()
thermostat.set_fan_mode("auto") thermostat.set_fan_mode("auto")
data.ecobee.set_fan_mode.assert_has_calls( data.ecobee.set_fan_mode.assert_has_calls(
[mock.call(1, "auto", 20, 40, "nextTransition")] [mock.call(1, "auto", "nextTransition", holdHours=None)]
) )