evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix fitbit oauth reauth debug logging (#105450)

Browse source
This commit is contained in:
Allen Porter 2023-12-10 14:09:58 -08:00 • committed by Franck Nijhof
parent 399f98a726
commit 0683b8be21
No known key found for this signature in database
GPG key ID: D62583BA8AB11CA3
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
homeassistant/components/fitbit/application_credentials.py
View file

@ -60,7 +60,10 @@ class FitbitOAuth2Implementation(AuthImplementation):
resp.raise_for_status() resp.raise_for_status()
except aiohttp.ClientResponseError as err: except aiohttp.ClientResponseError as err:
if _LOGGER.isEnabledFor(logging.DEBUG): if _LOGGER.isEnabledFor(logging.DEBUG):
error_body = await resp.text() if not session.closed else "" try:
error_body = await resp.text()
except aiohttp.ClientError:
error_body = ""
_LOGGER.debug( _LOGGER.debug(
"Client response error status=%s, body=%s", err.status, error_body "Client response error status=%s, body=%s", err.status, error_body
) )

3
tests/components/fitbit/test_init.py
View file

@ -107,18 +107,21 @@ async def test_token_refresh_success(
@pytest.mark.parametrize("token_expiration_time", [12345]) @pytest.mark.parametrize("token_expiration_time", [12345])
@pytest.mark.parametrize("closing", [True, False])
async def test_token_requires_reauth( async def test_token_requires_reauth(
hass: HomeAssistant, hass: HomeAssistant,
integration_setup: Callable[[], Awaitable[bool]], integration_setup: Callable[[], Awaitable[bool]],
config_entry: MockConfigEntry, config_entry: MockConfigEntry,
aioclient_mock: AiohttpClientMocker, aioclient_mock: AiohttpClientMocker,
setup_credentials: None, setup_credentials: None,
closing: bool,
) -> None: ) -> None:
"""Test where token is expired and the refresh attempt requires reauth.""" """Test where token is expired and the refresh attempt requires reauth."""
aioclient_mock.post( aioclient_mock.post(
OAUTH2_TOKEN, OAUTH2_TOKEN,
status=HTTPStatus.UNAUTHORIZED, status=HTTPStatus.UNAUTHORIZED,
closing=closing,
) )
assert not await integration_setup() assert not await integration_setup()