Avoid subprocess memory copy when c library supports posix_spawn (#87958)
* use posix spawn on alpine * Avoid subprocess memory copy when c library supports posix_spawn By default python 3.10 will use the fork() which has to copy all the memory of the parent process (in our case this can be huge since Home Assistant core can use hundreds of megabytes of RAM). By using posix_spawn this is avoided. In python 3.11 vfork will also be available https://github.com/python/cpython/issues/80004#issuecomment-1093810689 https://github.com/python/cpython/pull/11671 but we won't always be able to use it and posix_spawn is considered safer https://bugzilla.kernel.org/show_bug.cgi?id=215813#c14 The subprocess library doesn't know about musl though even though it supports posix_spawn https://git.musl-libc.org/cgit/musl/log/src/process/posix_spawn.c so we have to teach it since it only has checks for glibc1b736838e6/Lib/subprocess.py (L745)
The constant is documented as being able to be flipped here: https://docs.python.org/3/library/subprocess.html#disabling-use-of-vfork-or-posix-spawn * Avoid subprocess memory copy when c library supports posix_spawn By default python 3.10 will use the fork() which has to copy memory of the parent process (in our case this can be huge since Home Assistant core can use hundreds of megabytes of RAM). By using posix_spawn this is avoided and subprocess creation does not get discernibly slow the larger the Home Assistant python process grows. In python 3.11 vfork will also be available https://github.com/python/cpython/issues/80004#issuecomment-1093810689 https://github.com/python/cpython/pull/11671 but we won't always be able to use it and posix_spawn is considered safer https://bugzilla.kernel.org/show_bug.cgi?id=215813#c14 The subprocess library doesn't know about musl though even though it supports posix_spawn https://git.musl-libc.org/cgit/musl/log/src/process/posix_spawn.c so we have to teach it since it only has checks for glibc1b736838e6/Lib/subprocess.py (L745)
The constant is documented as being able to be flipped here: https://docs.python.org/3/library/subprocess.html#disabling-use-of-vfork-or-posix-spawn * missed some * adjust more tests * coverage
This commit is contained in:
parent
cf2fcdfba1
commit
03eea7bd3f
14 changed files with 84 additions and 9 deletions
|
@ -32,7 +32,10 @@ _LOGGER = logging.getLogger(__name__)
|
|||
def kill_raspistill(*args):
|
||||
"""Kill any previously running raspistill process.."""
|
||||
with subprocess.Popen(
|
||||
["killall", "raspistill"], stdout=subprocess.DEVNULL, stderr=subprocess.STDOUT
|
||||
["killall", "raspistill"],
|
||||
stdout=subprocess.DEVNULL,
|
||||
stderr=subprocess.STDOUT,
|
||||
close_fds=False, # required for posix_spawn
|
||||
):
|
||||
pass
|
||||
|
||||
|
@ -132,7 +135,10 @@ class RaspberryCamera(Camera):
|
|||
# Therefore it must not be wrapped with "with", since that
|
||||
# waits for the subprocess to exit before continuing.
|
||||
subprocess.Popen( # pylint: disable=consider-using-with
|
||||
cmd_args, stdout=subprocess.DEVNULL, stderr=subprocess.STDOUT
|
||||
cmd_args,
|
||||
stdout=subprocess.DEVNULL,
|
||||
stderr=subprocess.STDOUT,
|
||||
close_fds=False, # required for posix_spawn
|
||||
)
|
||||
|
||||
def camera_image(
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue