evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix entity registry comments (#20357)

Browse source
This commit is contained in:
Paulus Schoutsen 2019-01-23 16:33:21 -08:00 • committed by GitHub
parent a396ee2cb5
commit 0300ef2040
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
homeassistant/helpers/entity_registry.py
View file

@ -127,8 +127,8 @@ class EntityRegistry:
device_id=device_id, device_id=device_id,
# When we changed our slugify algorithm, we invalidated some # When we changed our slugify algorithm, we invalidated some
# stored entity IDs with either a __ or ending in _. # stored entity IDs with either a __ or ending in _.
# Fix introduced in 0.86 (Jan 23, 2018). Next line can be # Fix introduced in 0.86 (Jan 23, 2019). Next line can be
# removed when we release 1.0 or in 2019. # removed when we release 1.0 or in 2020.
new_entity_id='.'.join(slugify(part) for part new_entity_id='.'.join(slugify(part) for part
in entity_id.split('.', 1))) in entity_id.split('.', 1)))

9
tests/helpers/test_entity_registry.py
View file

@ -240,6 +240,10 @@ async def test_loading_invalid_entity_id(hass, hass_storage):
'entity_id': 'test.invalid_end_', 'entity_id': 'test.invalid_end_',
'platform': 'super_platform', 'platform': 'super_platform',
'unique_id': 'id-invalid-end', 'unique_id': 'id-invalid-end',
}, {
'entity_id': 'test._invalid_start',
'platform': 'super_platform',
'unique_id': 'id-invalid-start',
} }
] ]
} }
@ -256,3 +260,8 @@ async def test_loading_invalid_entity_id(hass, hass_storage):
'test', 'super_platform', 'id-invalid-end') 'test', 'super_platform', 'id-invalid-end')
assert valid_entity_id(entity_invalid_end.entity_id) assert valid_entity_id(entity_invalid_end.entity_id)
entity_invalid_start = registry.async_get_or_create(
'test', 'super_platform', 'id-invalid-start')
assert valid_entity_id(entity_invalid_start.entity_id)