From 0138caa277f96414d89d544e8e350357ecd2f53c Mon Sep 17 00:00:00 2001
From: epenet <6771947+epenet@users.noreply.github.com>
Date: Wed, 16 Feb 2022 21:40:11 +0100
Subject: [PATCH] Fix side_effect patching in samsungtv tests (#66651)

Co-authored-by: epenet <epenet@users.noreply.github.com>
---
 .../components/samsungtv/test_config_flow.py  | 26 ++++++++++---------
 .../components/samsungtv/test_media_player.py |  5 +---
 2 files changed, 15 insertions(+), 16 deletions(-)

diff --git a/tests/components/samsungtv/test_config_flow.py b/tests/components/samsungtv/test_config_flow.py
index a3e16ba81c3..c33424ed45b 100644
--- a/tests/components/samsungtv/test_config_flow.py
+++ b/tests/components/samsungtv/test_config_flow.py
@@ -267,7 +267,7 @@ async def test_user_websocket_not_supported(hass: HomeAssistant):
         "homeassistant.components.samsungtv.bridge.Remote",
         side_effect=OSError("Boom"),
     ), patch(
-        "homeassistant.components.samsungtv.bridge.SamsungTVWS",
+        "homeassistant.components.samsungtv.bridge.SamsungTVWS.open",
         side_effect=WebSocketProtocolException("Boom"),
     ):
         # websocket device not supported
@@ -284,7 +284,7 @@ async def test_user_not_successful(hass: HomeAssistant):
         "homeassistant.components.samsungtv.bridge.Remote",
         side_effect=OSError("Boom"),
     ), patch(
-        "homeassistant.components.samsungtv.bridge.SamsungTVWS",
+        "homeassistant.components.samsungtv.bridge.SamsungTVWS.open",
         side_effect=OSError("Boom"),
     ):
         result = await hass.config_entries.flow.async_init(
@@ -300,7 +300,7 @@ async def test_user_not_successful_2(hass: HomeAssistant):
         "homeassistant.components.samsungtv.bridge.Remote",
         side_effect=OSError("Boom"),
     ), patch(
-        "homeassistant.components.samsungtv.bridge.SamsungTVWS",
+        "homeassistant.components.samsungtv.bridge.SamsungTVWS.open",
         side_effect=ConnectionFailure("Boom"),
     ):
         result = await hass.config_entries.flow.async_init(
@@ -455,7 +455,7 @@ async def test_ssdp_websocket_not_supported(hass: HomeAssistant):
         "homeassistant.components.samsungtv.bridge.Remote",
         side_effect=OSError("Boom"),
     ), patch(
-        "homeassistant.components.samsungtv.bridge.SamsungTVWS",
+        "homeassistant.components.samsungtv.bridge.SamsungTVWS.open",
         side_effect=WebSocketProtocolException("Boom"),
     ):
         # device not supported
@@ -485,7 +485,7 @@ async def test_ssdp_not_successful(hass: HomeAssistant, no_mac_address: Mock):
         "homeassistant.components.samsungtv.bridge.Remote",
         side_effect=OSError("Boom"),
     ), patch(
-        "homeassistant.components.samsungtv.bridge.SamsungTVWS",
+        "homeassistant.components.samsungtv.bridge.SamsungTVWS.open",
         side_effect=OSError("Boom"),
     ), patch(
         "homeassistant.components.samsungtv.bridge.SamsungTVWSBridge.device_info",
@@ -513,7 +513,7 @@ async def test_ssdp_not_successful_2(hass: HomeAssistant, no_mac_address: Mock):
         "homeassistant.components.samsungtv.bridge.Remote",
         side_effect=OSError("Boom"),
     ), patch(
-        "homeassistant.components.samsungtv.bridge.SamsungTVWS",
+        "homeassistant.components.samsungtv.bridge.SamsungTVWS.open",
         side_effect=ConnectionFailure("Boom"),
     ), patch(
         "homeassistant.components.samsungtv.bridge.SamsungTVWSBridge.device_info",
@@ -925,12 +925,17 @@ async def test_autodetect_legacy(hass: HomeAssistant, remote: Mock):
 
 async def test_autodetect_none(hass: HomeAssistant):
     """Test for send key with autodetection of protocol."""
+    mock_remotews = Mock()
+    mock_remotews.__enter__ = Mock(return_value=mock_remotews)
+    mock_remotews.__exit__ = Mock()
+    mock_remotews.open = Mock(side_effect=OSError("Boom"))
+
     with patch(
         "homeassistant.components.samsungtv.bridge.Remote",
         side_effect=OSError("Boom"),
     ) as remote, patch(
         "homeassistant.components.samsungtv.bridge.SamsungTVWS",
-        side_effect=OSError("Boom"),
+        return_value=mock_remotews,
     ) as remotews:
         result = await hass.config_entries.flow.async_init(
             DOMAIN, context={"source": config_entries.SOURCE_USER}, data=MOCK_USER_DATA
@@ -1221,10 +1226,7 @@ async def test_form_reauth_websocket_cannot_connect(hass, remotews: Mock):
     assert result["type"] == "form"
     assert result["errors"] == {}
 
-    with patch(
-        "homeassistant.components.samsungtv.bridge.SamsungTVWS",
-        side_effect=ConnectionFailure,
-    ):
+    with patch.object(remotews, "open", side_effect=ConnectionFailure):
         result2 = await hass.config_entries.flow.async_configure(
             result["flow_id"],
             {},
@@ -1257,7 +1259,7 @@ async def test_form_reauth_websocket_not_supported(hass):
     assert result["errors"] == {}
 
     with patch(
-        "homeassistant.components.samsungtv.bridge.SamsungTVWS",
+        "homeassistant.components.samsungtv.bridge.SamsungTVWS.open",
         side_effect=WebSocketException,
     ):
         result2 = await hass.config_entries.flow.async_configure(
diff --git a/tests/components/samsungtv/test_media_player.py b/tests/components/samsungtv/test_media_player.py
index a274e0bbc98..ed09d9e33e0 100644
--- a/tests/components/samsungtv/test_media_player.py
+++ b/tests/components/samsungtv/test_media_player.py
@@ -296,10 +296,7 @@ async def test_update_connection_failure(hass, remotews, mock_now):
     ):
         await setup_samsungtv(hass, MOCK_CONFIGWS)
 
-        with patch(
-            "homeassistant.components.samsungtv.bridge.SamsungTVWS",
-            side_effect=ConnectionFailure("Boom"),
-        ):
+        with patch.object(remotews, "open", side_effect=ConnectionFailure("Boom")):
             next_update = mock_now + timedelta(minutes=5)
             with patch("homeassistant.util.dt.utcnow", return_value=next_update):
                 async_fire_time_changed(hass, next_update)