evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix google_asssistant sensor state reporting (#112838)

Browse source 
* Fix post google_assistant sensor values as float not string

* Fix aqi reporting and improve tests

* Fix _air_quality_description_for_aqi and  test
This commit is contained in:
Jan Bouwhuis 2024-03-12 09:07:20 +01:00 • committed by GitHub
parent 433d3a5106
commit 012291a1f3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 35 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

40
tests/components/google_assistant/test_trait.py
View file

@ -1,6 +1,7 @@
"""Tests for the Google Assistant traits."""
from datetime import datetime, timedelta
from typing import Any
from unittest.mock import ANY, patch
from freezegun.api import FrozenDateTimeFactory
@ -3926,16 +3927,15 @@ async def test_air_quality_description_for_aqi(hass: HomeAssistant) -> None:
BASIC_CONFIG,
)
assert trt._air_quality_description_for_aqi("0") == "healthy"
assert trt._air_quality_description_for_aqi("75") == "moderate"
assert trt._air_quality_description_for_aqi(0) == "healthy"
assert trt._air_quality_description_for_aqi(75) == "moderate"
assert (
trt._air_quality_description_for_aqi("125") == "unhealthy for sensitive groups"
trt._air_quality_description_for_aqi(125.0) == "unhealthy for sensitive groups"
)
assert trt._air_quality_description_for_aqi("175") == "unhealthy"
assert trt._air_quality_description_for_aqi("250") == "very unhealthy"
assert trt._air_quality_description_for_aqi("350") == "hazardous"
assert trt._air_quality_description_for_aqi("-1") == "unknown"
assert trt._air_quality_description_for_aqi("non-numeric") == "unknown"
assert trt._air_quality_description_for_aqi(175) == "unhealthy"
assert trt._air_quality_description_for_aqi(250) == "very unhealthy"
assert trt._air_quality_description_for_aqi(350) == "hazardous"
assert trt._air_quality_description_for_aqi(-1) == "unknown"
async def test_null_device_class(hass: HomeAssistant) -> None:
@ -3956,7 +3956,19 @@ async def test_null_device_class(hass: HomeAssistant) -> None:
assert trt.query_attributes() == {}
async def test_sensorstate(hass: HomeAssistant) -> None:
@pytest.mark.parametrize(
("value", "published", "aqi"),
[
(100.0, 100.0, "moderate"),
(10.0, 10.0, "healthy"),
(0, 0.0, "healthy"),
("", None, "unknown"),
("unknown", None, "unknown"),
],
)
async def test_sensorstate(
hass: HomeAssistant, value: Any, published: Any, aqi: Any
) -> None:
"""Test SensorState trait support for sensor domain."""
sensor_types = {
sensor.SensorDeviceClass.AQI: ("AirQuality", "AQI"),
@ -3978,7 +3990,7 @@ async def test_sensorstate(hass: HomeAssistant) -> None:
hass,
State(
"sensor.test",
100.0,
value,
{
"device_class": sensor_type,
},
@ -4024,16 +4036,14 @@ async def test_sensorstate(hass: HomeAssistant) -> None:
"currentSensorStateData": [
{
"name": name,
"currentSensorState": trt._air_quality_description_for_aqi(
trt.state.state
),
"rawValue": trt.state.state,
"currentSensorState": aqi,
"rawValue": published,
},
]
}
else:
assert trt.query_attributes() == {
"currentSensorStateData": [{"name": name, "rawValue": trt.state.state}]
"currentSensorStateData": [{"name": name, "rawValue": published}]
}
assert helpers.get_google_type(sensor.DOMAIN, None) is not None