evlli/hass-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove global variable from scsgate (#33719)

Browse source 
* Remove global variable from scsgate

* Import CONF_SCS_ID in light.py

* Run isort

* Remove constant ATTR_STATE
This commit is contained in:
springstan 2020-04-05 23:47:11 +02:00 • committed by GitHub
parent 40ce8f8c9c
commit 00e67fb2c7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 58 additions and 49 deletions
Download patch file Download diff file Expand all files Collapse all files

25
homeassistant/components/scsgate/light.py
View file

@ -4,15 +4,16 @@ import logging
from scsgate.tasks import ToggleStatusTask
import voluptuous as vol
from homeassistant.components import scsgate
from homeassistant.components.light import PLATFORM_SCHEMA, Light
from homeassistant.const import ATTR_ENTITY_ID, ATTR_STATE, CONF_DEVICES, CONF_NAME
import homeassistant.helpers.config_validation as cv
from . import CONF_SCS_ID, DOMAIN, SCSGATE_SCHEMA
_LOGGER = logging.getLogger(__name__)
PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend(
{vol.Required(CONF_DEVICES): cv.schema_with_slug_keys(scsgate.SCSGATE_SCHEMA)}
{vol.Required(CONF_DEVICES): cv.schema_with_slug_keys(SCSGATE_SCHEMA)}
)
@ -21,33 +22,37 @@ def setup_platform(hass, config, add_entities, discovery_info=None):
devices = config.get(CONF_DEVICES)
lights = []
logger = logging.getLogger(__name__)
scsgate = hass.data[DOMAIN]
if devices:
for _, entity_info in devices.items():
if entity_info[scsgate.CONF_SCS_ID] in scsgate.SCSGATE.devices:
if entity_info[CONF_SCS_ID] in scsgate.devices:
continue
name = entity_info[CONF_NAME]
scs_id = entity_info[scsgate.CONF_SCS_ID]
scs_id = entity_info[CONF_SCS_ID]
logger.info("Adding %s scsgate.light", name)
light = SCSGateLight(name=name, scs_id=scs_id, logger=logger)
light = SCSGateLight(
name=name, scs_id=scs_id, logger=logger, scsgate=scsgate
)
lights.append(light)
add_entities(lights)
scsgate.SCSGATE.add_devices_to_register(lights)
scsgate.add_devices_to_register(lights)
class SCSGateLight(Light):
"""Representation of a SCSGate light."""
def __init__(self, scs_id, name, logger):
def __init__(self, scs_id, name, logger, scsgate):
"""Initialize the light."""
self._name = name
self._scs_id = scs_id
self._toggled = False
self._logger = logger
self._scsgate = scsgate
@property
def scs_id(self):
@ -72,7 +77,7 @@ class SCSGateLight(Light):
def turn_on(self, **kwargs):
"""Turn the device on."""
scsgate.SCSGATE.append_task(ToggleStatusTask(target=self._scs_id, toggled=True))
self._scsgate.append_task(ToggleStatusTask(target=self._scs_id, toggled=True))
self._toggled = True
self.schedule_update_ha_state()
@ -80,9 +85,7 @@ class SCSGateLight(Light):
def turn_off(self, **kwargs):
"""Turn the device off."""
scsgate.SCSGATE.append_task(
ToggleStatusTask(target=self._scs_id, toggled=False)
)
self._scsgate.append_task(ToggleStatusTask(target=self._scs_id, toggled=False))
self._toggled = False
self.schedule_update_ha_state()